Cors features improvements #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
This change is |
k8s-ci-robot
added
the
size/L
|
Please do not merge yet, need to test this in a production environment. |
|
I'm just finishing some other tests, maybe tomorrow I'll release this. |
|
Need some help here. It seems controller is not returning any values to template. Although everything is working 'fine', any value used in ingress is discarded. I've put a comment in here but even setting the right annotation ( Probably is something small that I'm missing. The temporal image is Thanks! |
rikatz
force-pushed
the
cors-improvement
branch
from
f2dd452
to
89f18ba
Compare
CORS annotations improvements Cors improvements Cors improevements Cors improvements Cors improvements
rikatz
force-pushed
the
cors-improvement
branch
from
89f18ba
to
2097676
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Finished the PR. @aledbf Thanks for the help! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@rikatz thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds new forms to control CORS in a server, allowing user to specify not only if CORS is enabled, but also what are the allowed METHODS, HEADERS, the ORIGIN and credentials behaviour
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1171, fixes #676, fixes #625Special notes for your reviewer:
This PR adds 4 new annotations that allow user to control CORS behaviour in his ingress.
This code inserts some regex validations, as it's not desired that user is allowed to insert values as $nginx_version in allowed methods, as this is going to be returned directly to the final user and can cause an internal information leak, and also Ingress misconfiguration.