Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable features not availables in some platforms #1697

Merged
merged 1 commit into from
Nov 12, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 12, 2017

What this PR does / why we need it:

Some nginx modules are not available in specific platforms.
This PR disable the features to avoid runtime issues

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 36.765% when pulling 5095dd8762e60613cf788ad4d10f1dde8f88c403 on aledbf:disable-features into 0d2434f on kubernetes:master.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 36.803% when pulling fdd2318 on aledbf:disable-features into 0d2434f on kubernetes:master.

@aledbf aledbf merged commit 35363ff into kubernetes:master Nov 12, 2017
@aledbf aledbf deleted the disable-features branch November 12, 2017 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants