Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated methods. #1726

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Conversation

oilbeater
Copy link
Contributor

@oilbeater oilbeater commented Nov 19, 2017

Replace deprecate method client.Extensions()

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 19, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 36.097% when pulling f80c8fb on oilbeater:fix/deprecated into 76a4a00 on kubernetes:master.

@oilbeater
Copy link
Contributor Author

The coverage decrease seems not related to this pr.

@aledbf
Copy link
Member

aledbf commented Nov 19, 2017

@oilbeater please don't use the v1beta2 package. We need compatibility with 1.5 and 1.6

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 36.097% when pulling a3136aa on oilbeater:fix/deprecated into 76a4a00 on kubernetes:master.

@oilbeater
Copy link
Contributor Author

remove v1beta2 @aledbf

@aledbf
Copy link
Member

aledbf commented Nov 19, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2017
@aledbf
Copy link
Member

aledbf commented Nov 19, 2017

@oilbeater thanks!

@aledbf aledbf merged commit b0eb1cd into kubernetes:master Nov 19, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants