Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Config-Map Documentation Overhaul #1752

Merged
merged 1 commit into from
Nov 25, 2017

Conversation

diazjf
Copy link

@diazjf diazjf commented Nov 25, 2017

Changes the Config-Map documentation to be easier to search and follow a format similar to that in the annotations section. Also adds some missing configuration options. Fixes #1532

Changes the Config-Map documentation to be easier to search and follow
a format similar to that in the annotations section. Also adds some missing
configuration options.

Fixes kubernetes#1532
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 25, 2017
@diazjf
Copy link
Author

diazjf commented Nov 25, 2017

Note that the order of the configuration items is changed to match the order of the items in the table.

@diazjf diazjf mentioned this pull request Nov 25, 2017
24 tasks
@aledbf
Copy link
Member

aledbf commented Nov 25, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2017
@aledbf
Copy link
Member

aledbf commented Nov 25, 2017

@diazjf thanks!

@aledbf aledbf merged commit aded08a into kubernetes:master Nov 25, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.322% when pulling bb6ae76 on diazjf:cmap-docs into c13cdbf on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants