Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If server_tokens is disabled remove the Server header #1903

Merged
merged 3 commits into from
Jan 17, 2018
Merged

If server_tokens is disabled remove the Server header #1903

merged 3 commits into from
Jan 17, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 15, 2018

What this PR does / why we need it:

Removes the Server header when server-tokens: false. By default nginx only removes the version of nginx

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.64% when pulling c03f253 on aledbf:remove-server into a1afc41 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 36.777% when pulling cec4e62 on aledbf:remove-server into a1afc41 on kubernetes:master.

@coveralls
Copy link

coveralls commented Jan 17, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 36.777% when pulling 897c350 on aledbf:remove-server into a1afc41 on kubernetes:master.

@aledbf aledbf merged commit 8079322 into kubernetes:master Jan 17, 2018
@aledbf aledbf deleted the remove-server branch January 17, 2018 17:23
aledbf added a commit to aledbf/ingress-nginx that referenced this pull request Jan 18, 2018
@aledbf
If server_tokens is disabled remove the Server header (kubernetes#1903)
a07a563 
* If server_tokens is disabled remove the Server header

* Add server-tokens tests

* Fix tests
@bfin bfin mentioned this pull request Jun 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @k8s-ci-robot @k8s-reviewable @coveralls