Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random string function should only contains letters #1906

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 16, 2018

Which issue this PR fixes:

fixes #1902

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2018
@coveralls
Copy link

coveralls commented Jan 17, 2018

Coverage Status

Coverage increased (+0.05%) to 36.685% when pulling 5811af9 on aledbf:fix-name-generator into a1afc41 on kubernetes:master.

@aledbf aledbf merged commit 3e7d1f9 into kubernetes:master Jan 17, 2018
aledbf added a commit that referenced this pull request Jan 17, 2018
@aledbf aledbf deleted the fix-name-generator branch January 17, 2018 17:23
aledbf added a commit to aledbf/ingress-nginx that referenced this pull request Jan 18, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid geoip when using whitelist
4 participants