Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include lua-resty-lock in nginx image #2172

Merged
merged 1 commit into from
Mar 8, 2018
Merged

include lua-resty-lock in nginx image #2172

merged 1 commit into from
Mar 8, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
We need a synchronization/locking primitive available in Lua land to properly implement load balancing algorithms. You can see how is this being used for Round Robin implementation at https://github.com/Shopify/ingress/pull/16/files?w=1#diff-b00d77a6df9c8c05a483044b08e6bc50R38. But all the other algorithms that are in the roadmap will need some kind of locking. The PR adds https://github.com/openresty/lua-resty-lock to the Nginx image.

Which issue this PR fixes: N/A

Special notes for your reviewer: N/A

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2018
ElvinEfendi
ElvinEfendi commented Mar 6, 2018
View reviewed changes
images/nginx/build.sh
@@ -32,7 +32,7 @@ export OPENTRACING_CPP_VERSION=1.2.0
export ZIPKIN_CPP_VERSION=0.2.0
export JAEGER_VERSION=0.2.0
export MODSECURITY_VERSION=1.0.0
export LUA_VERSION=0.10.12rc2
export LUA_NGX_VERSION=0.10.12rc2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not directly related to the PR but I thought it is simple enough that does not require an additional separate PR. The reason I'm changing it is because all lua-resty-* libraries uses LUA_VERSION in the Makefile(for example: https://github.com/openresty/lua-resty-lock/blob/master/Makefile#L5) and they expect it to be the version of Lua interpreter running in the machine not the version of lua-nginx-module.

@ElvinEfendi
Copy link
Member Author

/assign @aledbf

@ElvinEfendi ElvinEfendi mentioned this pull request Mar 6, 2018
Merged
@ElvinEfendi
Copy link
Member Author

@aledbf anything you want me update in this PR? It would be great to get this merged and new Nginx image published so that CI gets fixed for #2174

@aledbf
Copy link
Member

aledbf commented Mar 8, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Mar 8, 2018

@ElvinEfendi thanks!

@aledbf aledbf merged commit dbbeffb into kubernetes:master Mar 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2018
@ElvinEfendi ElvinEfendi deleted the add-lua-resty-lock-library branch March 8, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElvinEfendi @aledbf @k8s-ci-robot