-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Lua balancer #2472
Refactor Lua balancer #2472
Conversation
/assign @aledbf |
/approve |
@ElvinEfendi I restarted the CI job several times so it seems the e2e error is real |
@aledbf yes, I can generate it locally too - debugging it now. |
Codecov Report
@@ Coverage Diff @@
## master #2472 +/- ##
=========================================
- Coverage 41.61% 41.6% -0.02%
=========================================
Files 74 74
Lines 5291 5290 -1
=========================================
- Hits 2202 2201 -1
Misses 2792 2792
Partials 297 297
Continue to review full report at Codecov.
|
/lgtm |
@ElvinEfendi: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I've included lua-resty-balancer library at #2385 which comes with Round-Robin load balancing implementation. The PR replaces the existing RR implementation with the one from that library. And also moves chash wrapper into rootfs/etc/nginx/lua/balancer/resty.lua together with round-robin.
In a separate PR I'll cleanup
balancer.lua
further - don't want to make this PR too big.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #n/a
Special notes for your reviewer:
n/a