Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Lua balancer #2472

Merged
merged 2 commits into from
May 10, 2018
Merged

Refactor Lua balancer #2472

merged 2 commits into from
May 10, 2018

Conversation

ElvinEfendi
Copy link
Member

@ElvinEfendi ElvinEfendi commented May 4, 2018

What this PR does / why we need it:
I've included lua-resty-balancer library at #2385 which comes with Round-Robin load balancing implementation. The PR replaces the existing RR implementation with the one from that library. And also moves chash wrapper into rootfs/etc/nginx/lua/balancer/resty.lua together with round-robin.

In a separate PR I'll cleanup balancer.lua further - don't want to make this PR too big.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
n/a

Special notes for your reviewer:
n/a

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 4, 2018
@ElvinEfendi ElvinEfendi changed the title Refactor round robin [WIP] Refactor round robin May 4, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2018
@ElvinEfendi ElvinEfendi changed the title [WIP] Refactor round robin Refactor Lua balancer May 10, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2018
@ElvinEfendi
Copy link
Member Author

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented May 10, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2018
@aledbf
Copy link
Member

aledbf commented May 10, 2018

@ElvinEfendi I restarted the CI job several times so it seems the e2e error is real

@ElvinEfendi
Copy link
Member Author

I restarted the CI job several times so it seems the e2e error is real

@aledbf yes, I can generate it locally too - debugging it now.

@codecov-io
Copy link

Codecov Report

Merging #2472 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2472      +/-   ##
=========================================
- Coverage   41.61%   41.6%   -0.02%     
=========================================
  Files          74      74              
  Lines        5291    5290       -1     
=========================================
- Hits         2202    2201       -1     
  Misses       2792    2792              
  Partials      297     297
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 65.45% <ø> (-0.08%) ⬇️
internal/file/bindata.go 62.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80365d...992a68d. Read the comment docs.

@ElvinEfendi
Copy link
Member Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@ElvinEfendi: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf
Copy link
Member

aledbf commented May 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c01d537 into kubernetes:master May 10, 2018
@ElvinEfendi ElvinEfendi deleted the refactor-round-robin branch May 10, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants