Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generate-request-id #2548

Merged
merged 1 commit into from
May 21, 2018
Merged

Implement generate-request-id #2548

merged 1 commit into from
May 21, 2018

Conversation

Stono
Copy link
Contributor

@Stono Stono commented May 21, 2018

Fixes #2546

Please let me know if this looks right! Would be great if you could do a test build for me to try out.

Thanks

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2018
@codecov-io
Copy link

Codecov Report

Merging #2548 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2548      +/-   ##
==========================================
+ Coverage    40.7%   40.71%   +0.01%     
==========================================
  Files          73       73              
  Lines        5034     5035       +1     
==========================================
+ Hits         2049     2050       +1     
  Misses       2711     2711              
  Partials      274      274
Impacted Files Coverage Δ
internal/ingress/controller/config/config.go 98.24% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d61eb2d...206d32a. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented May 21, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2018
@aledbf
Copy link
Member

aledbf commented May 21, 2018

@Stono thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Stono

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit b8b5e5b into kubernetes:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants