-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mount minikube volume to docker container #3261
Conversation
@zrdaley can you do this in a variable if the directory exists? (I removed the mount because it also breaks for those without minikube) |
This will help alot 👍 |
55b38a3
to
f8f8ae6
Compare
f8f8ae6
to
62a4342
Compare
Tested both positive and negative cases. Works Great!! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, zrdaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zrdaley thanks! |
Merging. |
What this PR does / why we need it:
This was removed here: f2bfc42#diff-431621728cbbd3bf22d1c9ac24b0d761L72
However, mounting the minikube volume to the docker container is essential for e2e-tests to run properly. Failing to do so results in the following error: