Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for IP Whitelist #3301

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Conversation

diazjf
Copy link

@diazjf diazjf commented Oct 26, 2018

Adds e2e test for the whitelist-source-range annotation.
Part of the #3124 effort.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2018
@ElvinEfendi
Copy link
Member

ElvinEfendi commented Oct 26, 2018

@diazjf thanks for all these e2e tests.

Can you default to treating the Nginx together with its generated configuration as a black box an assert on response headers/body? As a user I don't care how Nginx does it as long as it does what I want. In this specific PR (EDIT: this is actually about another PR #3302) for example, you can assert those specific headers you set using custom server snippet are actually included in response headers.

But I acknowledge that sometimes it's just good enough to assert generated configuration.

@aledbf
Copy link
Member

aledbf commented Oct 26, 2018

@diazjf please rebase to fix the e2e issue

@diazjf
Copy link
Author

diazjf commented Oct 26, 2018

/assign @aledbf

Adds e2e test for the whitelist-source-range annotation.
Part of the kubernetes#3124 effort.
@aledbf
Copy link
Member

aledbf commented Oct 26, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, diazjf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0e2ac45 into kubernetes:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants