Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node lister when --watch-namespace is used #343

Merged
merged 1 commit into from
Feb 24, 2017
Merged

Fix node lister when --watch-namespace is used #343

merged 1 commit into from
Feb 24, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 24, 2017

fixes #342

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.236% when pulling c6dd2db on aledbf:node-lister into 0134715 on kubernetes:master.

@joshrosso
Copy link
Contributor

You beat me to the PR. Thanks @aledbf 😄

@aledbf aledbf merged commit 8b7d9d1 into kubernetes:master Feb 24, 2017
@aledbf aledbf deleted the node-lister branch February 25, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node lookup fails when --watch-namspace is present on ingress controller
6 participants
@aledbf @k8s-reviewable @coveralls @joshrosso @bigkraig @k8s-ci-robot