Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin install location #3827

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

alexkursell
Copy link
Contributor

The url for the plugin manifest should actually be under releases.

cc: @aledbf

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2019
@aledbf
Copy link
Member

aledbf commented Feb 27, 2019

@alexkursell please check the release notes to install the plugin https://github.com/kubernetes/ingress-nginx/releases/tag/nginx-0.23.0 (--manifest only works with local files)

@alexkursell
Copy link
Contributor Author

@alexkursell please check the release notes to install the plugin https://github.com/kubernetes/ingress-nginx/releases/tag/nginx-0.23.0 (--manifest only works with local files)

Oh, that makes sense! I'll just copy what's present on the release page then.

@aledbf
Copy link
Member

aledbf commented Feb 27, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, alexkursell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit de2f760 into kubernetes:master Feb 27, 2019
@alexkursell alexkursell deleted the fix-plugin-install-docs branch February 27, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants