-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Modsecurity Snippet via ConfigMap #4087
Conversation
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4087 +/- ##
=========================================
Coverage ? 58.74%
=========================================
Files ? 88
Lines ? 7116
Branches ? 0
=========================================
Hits ? 4180
Misses ? 2490
Partials ? 446 Continue to review full report at Codecov.
|
/retest |
👋 Hello! I was wondering if there was any updates on this PR and/or is there anything I could do to help it along? This would be a massive addition as without custom snippets we cannot enable the ruleset in blocking mode, customize logging, add custom rules, or a number of other critical changes. Happy to help push this one over the finish line if any assistance is needed! |
I've rebased, asap i'll look into any failiing test |
5b51e74
to
e722166
Compare
/lgtm |
@MRoci thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, MRoci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
It would be handy to have a key in ConfigMap to define custom ModSecurity Rules shared across Ingresses, but now it's possible only with the annotation
nginx.ingress.kubernetes.io/modsecurity-snippet
.This PR adds
modsecurity-snippet
key, whose loading is subordinated to what is defined by the annotation