-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the kubernetes 1.14 version to the installation prompt #4678
Conversation
Hi @wawa0210. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@aledbf Can you review this pr |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4678 +/- ##
=========================================
Coverage ? 58.66%
=========================================
Files ? 88
Lines ? 6762
Branches ? 0
=========================================
Hits ? 3967
Misses ? 2356
Partials ? 439 Continue to review full report at Codecov.
|
docs/deploy/index.md
Outdated
@@ -37,6 +37,9 @@ The following **Mandatory Command** is required for all deployments. | |||
kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/static/mandatory.yaml | |||
``` | |||
|
|||
!!! tip | |||
If your kubernetes version is less than 1.14, you will need to change `kubernetes.io/os` to `beta.kubernetes.io/os`, see [Labels details](https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe If you are using a Kubernetes version previous to 1.14, you need to change...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, point to the line in mandatory.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done .
/lgtm |
@wawa0210 thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, wawa0210 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Added installation instructions for the kubernetes cluster before version 1.14
#4645
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: