Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken symlink to mimalloc #5357

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Fix broken symlink to mimalloc #5357

merged 1 commit into from
Apr 13, 2020

Conversation

sslavic
Copy link
Contributor

@sslavic sslavic commented Apr 13, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sslavic. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @sslavic!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2020
@sslavic
Copy link
Contributor Author

sslavic commented Apr 13, 2020

/assign @aledbf

@sslavic
Copy link
Contributor Author

sslavic commented Apr 13, 2020

bash-5.0$ ls -lart /usr/local/lib/
total 25504
drwxr-xr-x    3 root     root            23 Feb 21 19:21 perl5
-rwxr-xr-x    1 root     root       3618336 Feb 21 19:22 libluajit-5.1.so.2.1.0
lrwxrwxrwx    1 root     root            22 Feb 21 19:22 libluajit-5.1.so.2 -> libluajit-5.1.so.2.1.0
lrwxrwxrwx    1 root     root            22 Feb 21 19:22 libluajit-5.1.so -> libluajit-5.1.so.2.1.0
-rw-r--r--    1 root     root       4665322 Feb 21 19:22 libluajit-5.1.a
-rwxr-xr-x    1 root     root         48952 Feb 21 19:22 libopentracing.so.1.5.1
-rw-r--r--    1 root     root         68418 Feb 21 19:22 libopentracing.a
lrwxrwxrwx    1 root     root            23 Feb 21 19:22 libopentracing.so.1 -> libopentracing.so.1.5.1
lrwxrwxrwx    1 root     root            19 Feb 21 19:22 libopentracing.so -> libopentracing.so.1
-rwxr-xr-x    1 root     root       8726976 Feb 21 19:24 libjaegertracing_plugin.so
-rwxr-xr-x    1 root     root        207088 Feb 21 19:24 libzipkin.so.0.5.2
-rw-r--r--    1 root     root        325582 Feb 21 19:24 libzipkin.a
-rwxr-xr-x    1 root     root       7315456 Feb 21 19:24 libzipkin_opentracing_plugin.so
-rwxr-xr-x    1 root     root        351016 Feb 21 19:24 libzipkin_opentracing.so.0.5.2
-rw-r--r--    1 root     root        577336 Feb 21 19:24 libzipkin_opentracing.a
lrwxrwxrwx    1 root     root            30 Feb 21 19:24 libzipkin_opentracing.so.0 -> libzipkin_opentracing.so.0.5.2
lrwxrwxrwx    1 root     root            26 Feb 21 19:24 libzipkin_opentracing.so -> libzipkin_opentracing.so.0
lrwxrwxrwx    1 root     root            18 Feb 21 19:24 libzipkin.so.0 -> libzipkin.so.0.5.2
lrwxrwxrwx    1 root     root            14 Feb 21 19:24 libzipkin.so -> libzipkin.so.0
-rw-r--r--    1 root     root         45162 Feb 21 19:24 libmsgpackc.a
drwxr-xr-x    2 root     root            41 Feb 21 19:24 pkgconfig
drwxr-xr-x    4 root     root            40 Feb 21 19:24 cmake
-rwxr-xr-x    1 root     root         61944 Feb 21 19:25 libfuzzy.so.2.1.0
lrwxrwxrwx    1 root     root            17 Feb 21 19:25 libfuzzy.so.2 -> libfuzzy.so.2.1.0
lrwxrwxrwx    1 root     root            17 Feb 21 19:25 libfuzzy.so -> libfuzzy.so.2.1.0
-rwxr-xr-x    1 root     root           940 Feb 21 19:25 libfuzzy.la
-rw-r--r--    1 root     root         79950 Feb 21 19:25 libfuzzy.a
drwxr-xr-x    5 root     root            65 Feb 21 19:27 lua
drwxr-xr-x    3 root     root            23 Feb 21 19:27 luarocks
drwxr-xr-x    4 root     root           121 Feb 21 19:27 mimalloc-1.6
drwxr-xr-x    1 root     root            19 Feb 21 19:27 ..
lrwxrwxrwx    1 root     root            42 Feb 21 19:27 libmimalloc.so -> /usr/local/lib/mimalloc-1.2/libmimalloc.so
drwxr-xr-x    1 root     root            28 Feb 21 19:27 .

@aledbf
Copy link
Member

aledbf commented Apr 13, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2020
@aledbf
Copy link
Member

aledbf commented Apr 13, 2020

/lgtm
/approve

@aledbf
Copy link
Member

aledbf commented Apr 13, 2020

@sslavic thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, sslavic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 47a7048 into kubernetes:master Apr 13, 2020
@sslavic sslavic deleted the patch-1 branch April 13, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants