[GLBC] Update firewall source ranges if outdated #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
nicksardo
added
backend/gce
and removed
cncf-cla: yes
nicksardo
added
the
cncf-cla: yes
|
@aledbf You're welcome to review any PR of mine even if I assign it to others. |
bowei
reviewed
Apr 11, 2017
| existingCIDRs := sets.NewString(rule.SourceRanges...) | ||
|
|
||
| // Do not update if ports and source cidrs are not outdated. | ||
| // NOTE: We are not checking if nodeNames matches the firwall targetTags |
|
|
||
| // Do not update if ports and source cidrs are not outdated. | ||
| // NOTE: We are not checking if nodeNames matches the firwall targetTags | ||
| if requiredPorts.Equal(existingPorts) && requiredCIDRs.Equal(existingCIDRs) { | ||
| return nil |
| return nil | ||
| } | ||
|
|
||
| glog.V(3).Infof("Firewall rule %v already exists, updating nodeports %v", name, nodePorts) | ||
| return fr.cloud.UpdateFirewall(suffix, "GCE L7 firewall rule", fr.srcRanges, nodePorts, nodeNames) | ||
| } | ||
|
|
||
| // Shutdown shuts down this firewall rules manager. | ||
| func (fr *FirewallRules) Shutdown() error { | ||
| glog.Infof("Deleting firewall rule with suffix %v", fr.namer.FrSuffix()) |
There was a problem hiding this comment.
[minor] technically multiple rule(s)?
| @@ -0,0 +1,93 @@ | |||
| package firewalls | |||
| } | ||
| verifyFirewallRule(fwp, ruleName, nodePorts, nodes, l7SrcRanges, t) | ||
|
|
||
| all := "0.0.0.0/0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the second half of #197
Final task for that issue would be to consume the firewall rules from the GCE cloudprovider. Currently waiting on a PR over there...