Make custom-default-backend upstream name more unique.

[robinelfrink]

What this PR does / why we need it:

Make the custom-default-backend name more unique by adding the namespace.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #7465

How Has This Been Tested?

Built a new image with this change and used it to replace the one running in the test-cluster.
Ran curl-tests as described in #7465.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

@robinelfrink: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @robinelfrink!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @robinelfrink. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robinelfrink
To complete the pull request process, please assign strongjz after the PR has been reviewed.
You can assign the PR to them by writing /assign @strongjz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[longwuyuan]

/ok-to-test

[longwuyuan]

@rikatz @tao12345666333 @strongjz I think this needs to be cherry picked into dev-v1 as well. There is humour here in the context that hard to beleive same name of default-backend in a ingress spec, causes this problem, and was not detected for years because nobody would have thought about it..

Also, now it means there has to be a e2e test for same default-backend name, in the ingress resources spread across two different namespaces.

If you want I will create another issue to create new test and cherry picking into dev-v1.

[robinelfrink]

I need some help making the e2e tests work. In what namespace are tests created?

[longwuyuan]

I will check and let you know. But this will be a unique test because you need 2 namespaces. So maybe you can go ahead and add instrumentation for creating namespaces that will be be used only by your test. Let's see how it goes . Thanks, ; Long

…

On Wed, 11 Aug, 2021, 1:56 PM Robin Elfrink, ***@***.***> wrote: I need some help making the e2e tests work. In what namespace are tests created? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7479 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWQCQU3GGAQ5L7CMCJTT4IX3FANCNFSM5B5WKITQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[rikatz]

@robinelfrink thanks for the PR!
As this is critical, I'm gonna fix the e2e tests here locally and submit a PR later, accepting your now.

Just want to run some tests here. I'm also going to cherry pick this to dev-v1

If you are online, reach us at #ingress-nginx-dev at Slack so I can help you with cherry pick, etc (if you wanna do that)

[rikatz]

@robinelfrink this is how tests were fixed: https://github.com/kubernetes/ingress-nginx/pull/7486/files :)

As this was critical I decided to move forward, but feel free to reach us on ingress-nginx-dev