-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added specific details to RELEASE.md #7496
Conversation
@longwuyuan: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: longwuyuan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes: #7495 |
/area docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the base image section, I think you forgot the part, where we have to update the references to the promoted image. see this: https://github.com/kubernetes/ingress-nginx/pull/7473/files
@longwuyuan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* [generate-deploy-scripts.sh](https://github.com/kubernetes/ingress-nginx/blob/main/hack/generate-deploy-scripts.sh) | ||
* Open pull request with the updates | ||
* Merge | ||
## 6. Edit ghpages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed
Because old dev-v1 merged to main for releasing v1.0.0, my fork is way way way out of sync and I am not going to rebase it all. So I deleted my fork, hence I will close this PR. I will use backup of the lone file involved and create a new PR. |
What this PR does / why we need it:
Imroves documentation of RELEASE.md
Types of changes
Which issue/s this PR fixes
fixes #7495
-->
How Has This Been Tested?
Observed during release
Checklist: