-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new flag to watch ingressclass by name #7609
Conversation
@rikatz: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rikatz: GitHub didn't allow me to request PR reviews from the following users: janosi. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for more eyes
thanks
let me look |
@tao12345666333 as soon as you are ok, please remove the hold :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The new IngressClass logics watches for .spec.controller being the same of the controller when it starts. Some users complain (with reason) that they expect an ingress to be watched by the ingressClassName regardless of the .spec.controller from that object.
This PR adds a new flag:
--ingress-class-by-name
.Now, creating an ingressClass called "nginx-bla", for example, adding that in ingressClassName spec and running the controller with
--ingress-class-by-name --ingress-class=nginx-bla
will make the controller to watch for objects containing the .spec.controller but also just validate objects by name nginx-blaTypes of changes
Which issue/s this PR fixes
Fixes: #7502
How Has This Been Tested?
Wrote unit tests and e2e tests for the feature
/kind bug