-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only build nginx-errors for linux/amd64 #7625
Only build nginx-errors for linux/amd64 #7625
Conversation
@DysphoricUnicorn: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @DysphoricUnicorn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DysphoricUnicorn, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix wrong image location used in nginx-errors example config * Only build nginx-errors for linux/amd64
What this PR does / why we need it:
This PR changes the Makefile for the nginx-errors example to only build amd64 images.
This is done because the build is currently failing due to multiarch builds taking too many resources.
I also updated the container image link in the docs because I had accidentally used an incorrect one in my previous PR (#7460)
Types of changes
-> kind of, considering non-amd64 images will no longer be built automatically
How Has This Been Tested?
I built the images using the updated Makefile on my local Linux machine and it worked as expected.
Checklist: