Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images/kube-webhook-certgen/rootfs: add missing tests and fix regression #7801

Merged
merged 4 commits into from
Oct 12, 2021
Merged

images/kube-webhook-certgen/rootfs: add missing tests and fix regression #7801

merged 4 commits into from
Oct 12, 2021

Conversation

invidian
Copy link
Member

What this PR does / why we need it:

This PR adds missing tests implementation, which has not been added in #7641.

It also fixes an regression in not being able to patch only mutating webhook or only validating webhook.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

How Has This Been Tested?

Via unit tests + I plan to verify it as part of #7793.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@invidian
images/kube-webhook-certgen/rootfs: improve tests objects creation
cd1299a 
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@invidian
images/kube-webhook-certgen/rootfs: use context with deadline for tests
9f897d8 
So in case some operations are taking more time, we respect -timeout
flag.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@invidian
images/kube-webhook-certgen/rootfs: add missing tests implementation
d2729ce 
It should've been added in 9acf62d.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@invidian
images/kube-webhook-certgen/rootfs: fix patching only mutating webhook
a6509da 
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2021
@k8s-ci-robot
Copy link
Contributor

@invidian: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @invidian. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2021
@invidian invidian mentioned this pull request Oct 12, 2021
Merged
9 tasks
@rikatz
Copy link
Contributor

rikatz commented Oct 12, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2021
@rikatz
Copy link
Contributor

rikatz commented Oct 12, 2021

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 12, 2021
@rikatz
Copy link
Contributor

rikatz commented Oct 12, 2021

/lgtm
/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invidian, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5452364 into kubernetes:main Oct 12, 2021
@invidian invidian deleted the invidian/kube-webhook-certgen-add-missing-tests branch October 12, 2021 17:15
@invidian
Copy link
Member Author

invidian commented Oct 12, 2021 •
edited
Loading

@rikatz how should we promote the new image, since v1.1 is buggy? Can we override it or rather create v1.2? Or v1.1.1?

@invidian invidian mentioned this pull request Oct 12, 2021
Merged
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@invidian @rchshld
images/kube-webhook-certgen/rootfs: add missing tests and fix regress…
7f56802 
…ion (kubernetes#7801)

* images/kube-webhook-certgen/rootfs: improve tests objects creation

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>

* images/kube-webhook-certgen/rootfs: use context with deadline for tests

So in case some operations are taking more time, we respect -timeout
flag.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>

* images/kube-webhook-certgen/rootfs: add missing tests implementation

It should've been added in 9acf62d.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>

* images/kube-webhook-certgen/rootfs: fix patching only mutating webhook

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@invidian @k8s-ci-robot @rikatz