Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx/README.md: clarify app-root and fix example hyperlink #783

Merged
merged 1 commit into from
May 28, 2017
Merged

nginx/README.md: clarify app-root and fix example hyperlink #783

merged 1 commit into from
May 28, 2017
+2 −2

Conversation

unixwitch
Copy link
Contributor

The description was not very clear, and the referenced rewrite example has moved.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this May 28, 2017
@aledbf
Copy link
Member

aledbf commented May 28, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2017
@aledbf
Copy link
Member

aledbf commented May 28, 2017

@unixwitch thanks!

@aledbf aledbf merged commit f00823f into kubernetes:master May 28, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 46.573% when pulling 6d3e966 on unixwitch:nginx-app-root into bad009e on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@unixwitch @k8s-reviewable @aledbf @coveralls @k8s-ci-robot