Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ingress rbac roles #806

Merged
merged 1 commit into from
Jun 2, 2017
Merged

fix ingress rbac roles #806

merged 1 commit into from
Jun 2, 2017

Commits on Jun 2, 2017

  1. Fix kubernetes#798 - RBAC for leader election

    Using gcr.io/google_containers/nginx-ingress-controller:0.9.0-beta.7
    the nginx-controller needs to handle leader-election via configmaps.
    
    To perform the leader-election the nginx-controller needs to have the
    appropiate RBAC permissions.
    
    Previously to this fix, the following errors occured:
    
    -  cannot get configmaps in the namespace "NAMESPACE_PLACEHOLDER". (get configmaps ingress-controller-leader-nginx)
    - initially creating leader election record: User "system:serviceaccount:NAMESPACE_PLACEHOLDER" cannot create configmaps in the namespace "NAMESPACE_PLACEHOLDER". (post configmaps)
    
    fix ingress rbac roles
    
    There was 2 things that the current IC (0.9 beta7) needs.
    
    The ClusterRole was missing `get nodes`:
    
    ```
    RBAC DENY: user "system:serviceaccount:kube-system:nginx-ingress-controller" groups [system:serviceaccounts system:serviceaccounts:kube-system system:authenticated] cannot "get" resource "nodes" named "xxx" cluster-wide
    ```
    
    The Role was missing `update configmaps`:
    
    ```RBAC DENY: user "system:serviceaccount:kube-system:nginx-ingress-controller" groups [system:serviceaccounts system:serviceaccounts:kube-system system:authenticated] cannot "update" resource "configmaps" named "ingress-controller-leader-nginx" in namespace "kube-system"```
    
    removed update configmap because of kubernetes#798
    
    rebased on master, moved get nodes to own rule
    
    added get nodes to cluster permissions
    weitzj authored and puja108 committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    cf4ad26 View commit details
    Browse the repository at this point in the history