added step to install ginkgo if DIND environ #8566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@longwuyuan: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-kind
|
/assign @tao12345666333 @rikatz |
|
Considering the time consuming of this problem, let's move forward. We can make modifications in subsequent PRs, as well as upgrades of ginkgo versions, etc. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
samkulkarni20
added a commit
to samkulkarni20/ingress-nginx
that referenced
this pull request
Jun 10, 2022
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
rayandas
pushed a commit
to rayandas/ingress-nginx
that referenced
this pull request
Jan 25, 2023
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
rayandas
pushed a commit
to rayandas/ingress-nginx
that referenced
this pull request
May 2, 2023
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
rchshld
pushed a commit
to joomcode/ingress-nginx
that referenced
this pull request
May 19, 2023
rayandas
pushed a commit
to rayandas/ingress-nginx
that referenced
this pull request
Aug 21, 2023
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
chiukapoor
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Oct 11, 2023
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
vardhaman22
pushed a commit
to rancher/ingress-nginx
that referenced
this pull request
Nov 7, 2023
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
krunalhinguu
pushed a commit
to krunalhinguu/ingress-nginx
that referenced
this pull request
Dec 29, 2023
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
chiukapoor
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Feb 20, 2024
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
vardhaman22
pushed a commit
to vardhaman22/ingress-nginx
that referenced
this pull request
May 13, 2024
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
vardhaman22
pushed a commit
to vardhaman22/ingress-nginx
that referenced
this pull request
Jun 6, 2024
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
krunalhinguu
pushed a commit
to krunalhinguu/ingress-nginx
that referenced
this pull request
Aug 14, 2024
Fix flaky arm64 emulator issue docker/buildx#542 Use Go 1.17.2 and fix golint installation fix drone build failure `go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569 use go 1.21.5 | go mod tidy Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
krunalhinguu
pushed a commit
to krunalhinguu/ingress-nginx
that referenced
this pull request
Aug 20, 2024
Fix flaky arm64 emulator issue docker/buildx#542 Use Go 1.17.2 and fix golint installation fix drone build failure `go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569 use go 1.21.5 | go mod tidy Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
krunalhinguu
pushed a commit
to krunalhinguu/ingress-nginx
that referenced
this pull request
Aug 20, 2024
remove the upstream's workflow Add arm and s390x in the arches in scripts/build. only amd64 and arm64 was in arches because of this the CI wasn't able to find the following files with not found error. /bin/arm/nginx-ingress-controller, /bin/arm/wait-shutdown and /bin/arm/dbg fix drone build failure `go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569 use rancher's repository image remove depreview action revert back PR kubernetes#81 removed drone ci add drone's build and validate job in github actions workflow add release workflow which will run only while tagging added git in workflow steps for build and release remove G109 check till gosec resolves issues Remove test step from our CI Remove test step from our CI because it runs the upstream's e2e Go tests incorrectly and fails. Since we don't have any tests of our own, and upstream's CI already runs these tests, this step can be removed.
chiukapoor
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Sep 5, 2024
* replace upstream's workflow with Rancher's workflow files and add FOSSA * cherry pick commits: f327746, b8966a6 refactor rancher build process due to upstream changes and update docker version and buildx version * fix drone build failure `go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569 * Fix flaky arm64 emulator issue docker/buildx#542 Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
chiukapoor
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Sep 5, 2024
* replace upstream's workflow with Rancher's workflow files and add FOSSA * cherry pick commits: f327746, b8966a6 refactor rancher build process due to upstream changes and update docker version and buildx version * fix drone build failure `go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569 * Fix flaky arm64 emulator issue docker/buildx#542 Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
chiukapoor
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Sep 6, 2024
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
github-actions bot
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Sep 25, 2024
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
chiukapoor
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Oct 14, 2024
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
chiukapoor
pushed a commit
to chiukapoor/ingress-nginx
that referenced
this pull request
Oct 16, 2024
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo. This is making the drone build fail for arm64 arch. The ginkgo library gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images which typically install go libraries under $GOPATH/bin. Since the previously mentioned dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH to fix the build failure. See upstream PRs linked below for more info: kubernetes#8566 kubernetes#8569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
bash -c ginkgo ./test/e2e, very likely executes in GHActions-CI, with ginkgo installed. But same command in testgrid (testgrid reports broken #8552) fails, with error asginkgo not found. Laptop/local runs don't enable DIND so can not be reproduced in local (unless you hardcode DIND to "true")DOCKER_IN_DOCKERD_ENABLED="true"if condition, in line 71 of the script/build/run-in-docker.sh, which caused the invocation of the commandbash -c ./test/e2eELSEpart of the if condition on laptop/local where the command executed isdocker run ....and notginkgo buildginkgo not founderror in testgrid. Its not certain that the testgrid job will complete successfully in subsequent steps because the e2e binary will get built and exist only in that current environment. If Prow job sequence changes environment then the e2e binary will be missing. Its not easy to run testgrid prow job locally. So will fix issues if any when they come up. But the testgrid job run after this PR merges will provide lots of important feedback.Copy pasting part of the logs from testgrid job run. Note the bash echo statements that show the environment and the flow entering the if condition where DIND is checked. The debug marker line looks like this
..reached DIND check TRUE block, inside run-in-docker.sh. Checking environTypes of changes
Which issue/s this PR fixes
Related to #8552
How Has This Been Tested?
Can only be tested on testgrig prow job runs
Checklist: