-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace SIGTERM by SIGQUIT in waitshutdown to enable connection draining #8650
Conversation
waitshutdown is called in the prestop lifecycle hook, immediately when we ask pod termination, it seems we don't wait any time for draining existing connection which will be immediately dropped. Use SIGQUIT which wait connection to end before terminating nginx processus. http://nginx.org/en/docs/control.html https://medium.com/codecademy-engineering/kubernetes-nginx-and-zero-downtime-in-production-2c910c6a5ed8 Signed-off-by: Matthieu Paret <matthieu.paret@lifen.fr>
@mtparet: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @mtparet. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mtparet The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems it is already a |
Same issue/solution here #6928 (comment) |
What this PR does / why we need it:
SIGTERM kill nginx processus without draining connection because it is a "fast shutdown".
As waitshutdown is called in the prestop lifecycle hook, immediately when we ask for pod termination, it means we don't
wait any time for draining existing connections which will be immediately dropped.
Use SIGQUIT which waits connections to end before terminating nginx processus.
References :
http://nginx.org/en/docs/control.html
https://medium.com/codecademy-engineering/kubernetes-nginx-and-zero-downtime-in-production-2c910c6a5ed8
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Start nginx
Open a telnet ongoing connection
Send a SIGTERM
Observe that connection is immediately terminated and nginx process are killed.
Restart nginx container and the telnet command.
Send a SIGQUIT
Observe that the connection is not terminated and all nginx process are not killed (only idle nginx are terminated)
Checklist: