-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to allow sticky sessions per location #871
Conversation
@rikatz ping |
6d036d2
to
a8d9c8e
Compare
Coverage increased (+0.02%) to 46.673% when pulling a8d9c8eb24c0291a86bc64c6631068a89a0181e2 on aledbf:fix-sticky into c6b5335 on kubernetes:master. |
@aledbf What happens here if we have multiple ingresses pointing to the same 'host', some with sticky enabled, other with only whitelist enabled? Is there any conflict here that may happen? I'll test this probably between today and tomorrow and will provide you a feedback :) |
No. |
@aledbf I just follow these steps on my env, but I can not see anything like this: after run : kubectl exec -n kube-system -- curl -v localhost -H'Host: sticky-ingress.example.com' just some output like this:
< HTTP/1.1 200 OK
Hostname: http-svc-tzdt8 Pod Information: Server values: Request Information: Request Headers: Request Body: I am using kubernetes 1.5.7 and nginx 0.9-beta.11 |
This PR enables sticky session per location inside a server
Also avoids reusing the same upstream block when sticky sessions is not configured
Check sticky sessions is working:
It must appear something like
Check a different host with no sticky sessions that uses the same service:
Now check a different path in the host with sticky sessions where the feature is not enabled:
fixes #844
fixes #771