Add flag to skip the update of Ingress status on shutdown #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
justinsb
reviewed
Jun 20, 2017
| @@ -89,6 +89,10 @@ func NewIngressController(backend ingress.Controller) *GenericController { | |||
| forceIsolation = flags.Bool("force-namespace-isolation", false, | |||
| `Force namespace isolation. This flag is required to avoid the reference of secrets or | |||
| configmaps located in a different namespace than the specified in the flag --watch-namespace.`) | |||
|
|
|||
| statusUpdateOnShutdown = flags.Bool("update-status-on-shutdown", true, `Indicates if the | |||
| ingress controller should NOT update the Ingress status IP/hostname when the controller | |||
There was a problem hiding this comment.
Nit: This could probably just be should update the Ingress ... i.e. I think "not" is wrong there.
|
LGTM |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
justinsb
reviewed
Jun 20, 2017
| ElectionID string | ||
| UpdateStatus bool | ||
| ElectionID string | ||
| StatusUpdateOnShutdown bool |
There was a problem hiding this comment.
Another nit - I'm not sure if this is exposed anywhere, but it probably should be UpdateStatusOnShutdown to mirror the flag name
aledbf
force-pushed
the
avoid-status-updtae
branch
from
bf9be4c
to
d6aeecc
Compare
aledbf
force-pushed
the
avoid-status-updtae
branch
from
d6aeecc
to
05a976f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #881