-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native histogram support for histogram metrics #9971
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @rabenhorst! |
Hi @rabenhorst. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/auto-cc @ElvinEfendi |
This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach |
The This bot removes
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /remove-lifecycle frozen |
Assuming a huge metrics cardinality from ingress controllers, exposing native histogram would help a lot. |
@Cheshirez for the readers who know nothing about the histograms and the variants like native or classic, this PR is hard to wrap one's head around. What is required is the screesnhots, data and explaining all together, copy/paste here for everyone to read and understand. That will likely cause a thought on what the improvement is and how its relevant to what group of users. It also requires to help out with info on the impact of maintaining & supporting. That kind of insight is missing here. It requires the rare prometheus maintainer level experts and they are hard to come by, to spend their time here. Any help is appreciated. |
@rabenhorst Any plans to continue with this PR? |
Sry I was on holiday. Yes I can work on this. I'm not a Prometheus maintainer, but added (partial) native histogram support for Thanos and know my way around in Prometheus. @longwuyuan I will rebase and update the PR description accordingly in the coming days. |
@rabenhorst are you still willing to work on this? |
@rikatz ,if rebased and passing tests, then its ok to accept this because optional observabiity flag being added here helps because it is optional. |
0c88372
to
d969d63
Compare
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
55cb35a
to
fdd69c7
Compare
Hi Sebastian, thanks for the contribution. Hoping you will copy paste some screenshots of histograms resulting from your changes. Helps get perspective. Also requesting you squash commits kindly. |
I will. There also will be a talk about our migration to native histograms on PromCon https://promcon.io/2024-berlin/talks/shopifys-journey-from-conventional-to-native-histograms/ if you are interested in the wider topic of native histograms. Will squash all commits now. Is the failing lint expected? |
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Fixed flag Added cli docs Fxi cli args doc Fxi cli args doc Fxi cli args doc Fxi cli args doc Revert "Fxi cli args doc" This reverts commit b0dd2de6e032cefbdb06cead85b0b9be16abcd22. Revert "Fxi cli args doc" This reverts commit 6afc0f7a1c9bfba4ee75dbb99be1b9fbba4df156. Revert "Fxi cli args doc" This reverts commit 1f6c408e1220745bd1279b1aeaf854c748adf754. Revert "Fxi cli args doc" This reverts commit 68beccbd50be56b4f8aa461b6c3685f927e02413. Fix cli args docs Fix cli args docs Fix cli args docs
fdd69c7
to
fcbcc7b
Compare
That is awesome. Will try to sync. I hope you will put in some brief description in docs about how native histograms are different and their benefits. Thanks again for this contribution being optional config. |
I am on phone. Will get on computer and comment on lint. |
@rikatz linter caught 2 deprecations. Needs your comment
@tao12345666333 PTAL |
Yeah these linter comments are new and unrelated. I am fixing those on another PR, let me see if I can expedite these fixes and then merge this one |
#11853 fixing the linter here, then we can rebase and re-run this test |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rabenhorst, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR exposes native histogram configuration for histogram metrics as flags. Without setting the flags, behavior won't change. Native histograms are only scraped when both Prometheus and the client support it and have it enabled, otherwise classic histograms will be scraped.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Ran ingress-nginx in a local Kubernetes cluster using
make dev-env
and scraped it with Prometheus with native histograms enabled and disabled.Checklist: