Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to describe how to backfill pre-VDF images into post-VDF subdir path #1282

Closed
listx opened this issue Sep 25, 2020 · 6 comments
Assignees
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@listx
Copy link
Contributor

listx commented Sep 25, 2020

Problem: After the vanity domain flip happened, there are now N subprojects with their own subdirs underneath k8s.gcr.io/<SUBDIR>. This is fine. But now we would like to backfill pre-VDF images that currently live in k8s.gcr.io/<OLD_IMAGE> into k8s.gcr.io/<SUBDIR>/<OLD_IMAGE>. This way, any new post-VDF references that use the SUBDIR prefix can also refer to old images that were built before the VDF happened, using the same SUBDIR prefix.

In other words, all images in k8s.gcr.io that don't live under a staging subproject's SUBDIR should be given a SUBDIR and copied there.

What we want to do is just list the old images in images.yaml to make sure they also exist under the subproject's SUBDIR. However, this won't work on its own because the staging repo won't have these images. So there are at least 2 steps involved:

  1. Copy pertinent old images from k8s.gcr.io root into gcr.io/k8s-staging-SUBPROJECT.
  2. Add images from Step 1 into the images.yaml for gcr.io/k8s-staging-SUBPROJECT, to promote into k8s.gcr.io/SUBPROJECT-SUBDIR/<old_image>.

This involves some trivial shell logic, probably. But we could just start with some docs.

@listx
Copy link
Contributor Author

listx commented Sep 25, 2020

Which sample projects need backfilling first? @thockin @justaugustus

@listx
Copy link
Contributor Author

listx commented Sep 25, 2020

/assign @listx

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2020
@spiffxp
Copy link
Member

spiffxp commented Jan 20, 2021

/kind documentation
/wg k8s-infra
/area artifacts
/sig release
/area release-eng
/assign @justaugustus @hasheddan
FYI @kubernetes/release-engineering
Is this still relevant?

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. wg/k8s-infra area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 20, 2021
@justaugustus
Copy link
Member

Given we've done the VDF in kubernetes/release#270 and all images were backfilled, I'd say let's close this.

For RelEng, I copied the last two or three versions of our images and promoted those ahead of VDF.
I'd suggest subprojects that need similar to do the same in a post-VDF world, instead of having us sign up for the discovery work, which I think ultimately will be low-value in comparison.

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

Given we've done the VDF in kubernetes/release#270 and all images were backfilled, I'd say let's close this.

For RelEng, I copied the last two or three versions of our images and promoted those ahead of VDF.
I'd suggest subprojects that need similar to do the same in a post-VDF world, instead of having us sign up for the discovery work, which I think ultimately will be low-value in comparison.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject kind/documentation Categorizes issue or PR as related to documentation. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

6 participants