Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hook up build clusters to prow staging instance #1475

Closed
ameukam opened this issue Dec 10, 2020 · 9 comments
Closed

hook up build clusters to prow staging instance #1475

ameukam opened this issue Dec 10, 2020 · 9 comments
Labels
area/apps/prow k8s-infra-prow.k8s.io, code in apps/prow/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone
v1.23

Comments

@ameukam
Copy link
Member

ameukam commented Dec 10, 2020

Part of #1394

  • ensure aaa cluster has network access to k8s-infra-prow-build and k8s-infra-prow-build-trusted build clusters
  • Generate kubeconfig config (and credentials) for k8s-infra-prow-build and k8s-infra-prow-build-trusted and them as secrets in namespace prow (in aaa cluster). see prow doc

/area prow
/sig testing
/wg k8s-infra
@k8s-ci-robot k8s-ci-robot added area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 10, 2020
@spiffxp
Copy link
Member

spiffxp commented Dec 10, 2020

I would hold off on this until you've documented more of a transition plan.

To date, I'm not sure we have successfully had two prow service clusters pointed at the same build cluster. There are a number of potentially-dueling prow components to consider. @chaodaiG was looking into this recently for a different prow/build-cluster for a different project (ref: kubernetes/test-infra#14343)

The issue I am aware of off the top of my head is that sinker consider pods that do have prow-related labels, but are not in the service cluster's registry as orphans, and delete them. This means if you point the prow staging instance at k8s-infra-prow-build, it will delete any pods it hasn't scheduled. See https://github.com/kubernetes/test-infra/blob/8f5082828ae02af9ae105119730f18ae0609678c/prow/cmd/sinker/main.go#L475-L493

@spiffxp
Copy link
Member

spiffxp commented Dec 10, 2020

cc @BenTheElder @amwat

@ameukam ameukam mentioned this issue Jan 20, 2021
Closed
9 tasks
@ameukam
Copy link
Member Author

ameukam commented Feb 23, 2021 •
edited
Loading

As discussed during SIG testing meeting on 02/23/2021, we can deploy the staging again k8s-infra-prow-build and k8s-infra-prow-build-trusted using a different namespace than test-pods.

ameukam added a commit to ameukam/k8s.io that referenced this issue Feb 25, 2021
@ameukam
Add namespaces for prow staging
428bcb1 
Add namespaces to prow build clusters that will be used by the prow
staging instance.

We are experimenting with the possibility that more than one prow
instance can run against the same build cluster.

Ref: kubernetes#1475

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam mentioned this issue Feb 25, 2021
Merged
@ameukam
Copy link
Member Author

ameukam commented Apr 16, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 16, 2021
ameukam added a commit to ameukam/k8s.io that referenced this issue Jul 16, 2021
@ameukam
prow: Add k8s-infra-build-clusters-kubeconfig ExternalSecret
ab142fd 
Ref: kubernetes#1475
Umbrella issue: kubernetes#1394

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam mentioned this issue Jul 16, 2021
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2021
@ameukam
Copy link
Member Author

ameukam commented Jul 17, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2021
@spiffxp
Copy link
Member

spiffxp commented Aug 4, 2021

/milestone v1.23
/priority important-soon
/area apps/prow

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/apps/prow k8s-infra-prow.k8s.io, code in apps/prow/ labels Aug 4, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.23 Aug 4, 2021
This was referenced Aug 12, 2021
Merged
Merged
Merged
ameukam added a commit to ameukam/k8s.io that referenced this issue Sep 23, 2021
@ameukam
apps/prow: Use KUBECONFIG env. variable
c2ef9ce 
Ref: kubernetes#2559
Part of kubernetes#1475

It's possible the kubeconfig is incorrectly parsed. Testing this theory.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member Author

ameukam commented Sep 24, 2021

This was blocked by #2559.
I think we can it call done.

/close

@k8s-ci-robot
Copy link
Contributor

@ameukam: Closing this issue.

In response to this:

This was blocked by #2559.
I think we can it call done.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/apps/prow k8s-infra-prow.k8s.io, code in apps/prow/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
v1.23
Development

No branches or pull requests
4 participants
@spiffxp @ameukam @k8s-ci-robot @fejta-bot