Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup ghproxy in k8s-infra-prow-build-trusted #843

Closed
spiffxp opened this issue May 6, 2020 · 20 comments
Closed

Setup ghproxy in k8s-infra-prow-build-trusted #843

spiffxp opened this issue May 6, 2020 · 20 comments
Assignees
@spiffxp @ameukam
Labels
area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
sig-k8s-infra sig-testing issues
Milestone
v1.31

Comments

@spiffxp
Copy link
Member

spiffxp commented May 6, 2020 •
edited

(ghProxy)[https://github.com/kubernetes/test-infra/tree/master/ghproxy] is a reverse proxy HTTP cache optimized for use with the GitHub API. Jobs that manage our github orgs and repos (label_sync, peribolos) greatly benefit from this, and at this point probably won't run without it.

Today, the google.com prow.k8s.io cluster acting as "trusted build cluster" (k8s-prow/prow)has it deployed to its own nodepool (label dedicate:ghproxy)

  • node: n1-standard-8, 100 GB pd-standard, COS
  • volume: 100Gi, pd-ssd, gce-ssd-retain storageclass (defined in test-infra/config/prow/cluster)

ref: #752, followup to: #830
@spiffxp spiffxp added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels May 6, 2020
This was referenced May 6, 2020
Merged
Closed
@spiffxp spiffxp added the area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters label May 7, 2020
@spiffxp spiffxp added this to Backlog in sig-k8s-infra May 11, 2020
@ameukam
Copy link
Member

ameukam commented May 28, 2020

/assign

@ameukam
Copy link
Member

ameukam commented May 28, 2020

@spiffxp I started to look at ghproxy and I'm curious about something: is pushgateway a hard requirement for ghproxy ?

@ameukam ameukam mentioned this issue May 29, 2020
Merged
@bartsmykla
Copy link
Contributor

bartsmykla commented Jun 1, 2020 •
edited

@ameukam it looks like it's an endpoint for prometheus metrics to be exposed, but looking at: k/test-infra/ghproxy/ghproxy.go#L122 I would understand it can be ommited and I would suggest to to it at this point.

Edit:

Looking at k/test-infra/prow/metrics/metrics.go to not expose the metrics there still needs to be passed --push-gateway flag with no --serve-metrics flag or it set to false as when --push-gateway is not set it would ignore --serve-metrics set to false.

BTW. @fejta should it work that way or is it a bug?

@ameukam ameukam mentioned this issue Jun 9, 2020
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2020
@ameukam
Copy link
Member

ameukam commented Aug 30, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2020
@spiffxp spiffxp mentioned this issue Oct 15, 2020
Closed
ameukam added a commit to ameukam/test-infra that referenced this issue Oct 16, 2020
@ameukam
Add canary job for ci-org-peribolos
cbd3a8d 
Add a canary for ci-org-peribolos that validates ghproxy (ref:
kubernetes/k8s.io#843) for k8s-infra-prow-build-trusted.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam mentioned this issue Oct 16, 2020
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Oct 28, 2020

/assign
need to provide token to trusted cluster for ghproxy

@spiffxp
Copy link
Member Author

spiffxp commented Jan 14, 2021

Blocked on kubernetes/test-infra#11402 (comment)

@spiffxp spiffxp moved this from Backlog to Blocked in sig-k8s-infra Jan 20, 2021
@spiffxp spiffxp added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 22, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2021
@ameukam
Copy link
Member

ameukam commented Apr 23, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 9, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jul 9, 2021
@spiffxp spiffxp added this to To Triage in sig-testing issues Jul 27, 2021
@ameukam
Copy link
Member

ameukam commented Aug 9, 2021

ghproxy is up and running on k8s-infra-prow-builder-cluster-trusted.
Auto-upgrade is enabled for it : #2402.
The k8s-triage-robot prowjobs use it: kubernetes/test-infra#23103.

Considered done when kubernetes/test-infra#11402 (comment) is addressed.

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. and removed wg/k8s-infra labels Sep 29, 2021
@ameukam
Copy link
Member

ameukam commented Dec 6, 2021

/milestone v1.24

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.23, v1.24 Dec 6, 2021
@ameukam
Copy link
Member

ameukam commented Feb 12, 2022

/milestone clear
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 12, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Feb 12, 2022
@ameukam ameukam removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Nov 15, 2023
@ameukam
Copy link
Member

ameukam commented Nov 15, 2023

we can resume this now we have control of k8s-ci-robot

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2024
@ameukam
Copy link
Member

ameukam commented Feb 13, 2024

/remove-lifecycle stale
/milestone v1.31

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Feb 13, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2024
@ameukam
Copy link
Member

ameukam commented May 14, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 14, 2024
@ameukam
Copy link
Member

ameukam commented Jul 25, 2024

This can be closed.

kubernetes/test-infra#11402 (comment)

/close

@k8s-ci-robot
Copy link
Contributor

@ameukam: Closing this issue.

In response to this:

This can be closed.

kubernetes/test-infra#11402 (comment)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sig-k8s-infra automation moved this from Blocked to Done Jul 25, 2024
sig-testing issues automation moved this from To Triage to Done Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spiffxp spiffxp

@ameukam ameukam

Labels
area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
SIG K8S Infra
Status: Done
sig-k8s-infra
  
Done
sig-testing issues
  
Done
Milestone
v1.31
Development

No branches or pull requests
6 participants
@spiffxp @ameukam @bartsmykla @k8s-ci-robot @fejta-bot @k8s-triage-robot