Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k8s-release-dev bucket to gcsweb #1195

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Add k8s-release-dev bucket to gcsweb #1195

merged 1 commit into from
Aug 31, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 31, 2020

Followup to #1110
Part of #846

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2020
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 31, 2020

/cc @justaugustus
FYI @kubernetes/release-engineering

hasheddan
hasheddan approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6ab5cd6 into kubernetes:master Aug 31, 2020
@spiffxp spiffxp deleted the update-gcsweb-buckets branch August 31, 2020 22:45
@spiffxp
Copy link
Member Author

spiffxp commented Aug 31, 2020

I'm guessing this needs to be manually deployed...

@spiffxp
Copy link
Member Author

spiffxp commented Aug 31, 2020 

spiffxp@cloudshell:~/k8s.io/gcsweb.k8s.io (k8s-infra-prow-build)$ k --context=gke_kubernetes-public_us-central1_aaa apply -f deployment.yaml --namespace gcsweb
deployment.extensions/gcsweb configured

@spiffxp spiffxp mentioned this pull request Aug 31, 2020
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Aug 31, 2020

Now that #1196 has merged and been deployed, I can visit https://gcsweb.k8s.io/gcs/k8s-release-dev/ and see that so far nothing has been placed there

@spiffxp spiffxp mentioned this pull request Oct 8, 2020
Closed
@spiffxp spiffxp mentioned this pull request Jul 29, 2021
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@ixdy ixdy Awaiting requested review from ixdy

@thockin thockin Awaiting requested review from thockin

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan