-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add staging GCR repo for Kubernetes CI images #1355
Add staging GCR repo for Kubernetes CI images #1355
Conversation
/assign @spiffxp @justaugustus |
/retitle Add staging GCR repo for Kubernetes CI images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits on the approvers/reviewers/IAM in its current state.
Question to @spiffxp (repost from https://github.com/kubernetes/test-infra/pull/19574/files#r508025503):
Any reason to not use GCR in the k8s-release
project: #1110, #846 (comment)
The intent of that project was to use it for CI artifacts.
(Right now, the gs://k8s-release-dev
and gs://k8s-release-pull
buckets live there.)
groups/sig-release/groups.yaml
Outdated
- ameukam@gmail.com | ||
- bentheelder@google.com | ||
- davanum@gmail.com | ||
- linusa@google.com | ||
- spiffxp@google.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, this is instead:
- IAM for Test Infra folks
- IAM for WG K8s Infra Leads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend k8s-infra-prow-oncall@kubernetes.io
instead
- ameukam@gmail.com | |
- bentheelder@google.com | |
- davanum@gmail.com | |
- linusa@google.com | |
- spiffxp@google.com | |
- k8s-infra-prow-oncall@kubernetes.io | |
- ameukam@gmail.com |
I don't think @listx needs to be included here. @ameukam I would support you moving to k8s-infra-prow-oncall if you're interested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to not use GCR in the k8s-release project: #1110, #846 (comment)
- avoiding special cases for the pile of bash that maintains all this; k8s-artifacts-prod and the staging projects are the only projects that have populated GCR repositories and I think it would be better to keep it that way
- GCR repos match project id, so it would have to be gcr.io/k8s-release; I think that's not quite an analogue to kubernetes-ci-images, and might be confusing to see non-releases there
/approve
/lgtm
groups/sig-release/groups.yaml
Outdated
- ameukam@gmail.com | ||
- bentheelder@google.com | ||
- davanum@gmail.com | ||
- linusa@google.com | ||
- spiffxp@google.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend k8s-infra-prow-oncall@kubernetes.io
instead
- ameukam@gmail.com | |
- bentheelder@google.com | |
- davanum@gmail.com | |
- linusa@google.com | |
- spiffxp@google.com | |
- k8s-infra-prow-oncall@kubernetes.io | |
- ameukam@gmail.com |
I don't think @listx needs to be included here. @ameukam I would support you moving to k8s-infra-prow-oncall if you're interested
@spiffxp Very interested in being part of this group. Always happy to give some help. :-) |
Add a GCR staging repo that will host images built by ci-kubernetes-build jobs. It will help migrate those jobs to k8s-infra-prow-build-cluster. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Okay, let's party! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, justaugustus, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was created to support kubernetes/test-infra#19483 |
@ameukam Do we still need I'm working on applying #4277 to all the manifests.
|
This project is used to build "hourly" k8s images used by other prowjobs. There is no image promotion for this project. |
Add a GCR staging repo that will host images built by
ci-kubernetes-build jobs. It will help migrate those jobs
to k8s-infra-prow-build-cluster.
Signed-off-by: Arnaud Meukam ameukam@gmail.com