Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add staging GCR repo for Kubernetes CI images #1355

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Add staging GCR repo for Kubernetes CI images #1355

merged 1 commit into from
Oct 23, 2020

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 22, 2020

Add a GCR staging repo that will host images built by
ci-kubernetes-build jobs. It will help migrate those jobs
to k8s-infra-prow-build-cluster.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2020
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra labels Oct 22, 2020
@ameukam
Copy link
Member Author

ameukam commented Oct 22, 2020

/assign @spiffxp @justaugustus
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2020
@justaugustus
Copy link
Member

/retitle Add staging GCR repo for Kubernetes CI images

@k8s-ci-robot k8s-ci-robot changed the title Add Staging GCR repo for kuberntes CI images. Add staging GCR repo for Kubernetes CI images Oct 22, 2020
justaugustus
justaugustus suggested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits on the approvers/reviewers/IAM in its current state.

Question to @spiffxp (repost from https://github.com/kubernetes/test-infra/pull/19574/files#r508025503):

Any reason to not use GCR in the k8s-release project: #1110, #846 (comment)

The intent of that project was to use it for CI artifacts.
(Right now, the gs://k8s-release-dev and gs://k8s-release-pull buckets live there.)

groups/sig-release/groups.yaml Outdated Show resolved Hide resolved
groups/sig-release/groups.yaml Outdated
Comment on lines 117 to 121
- ameukam@gmail.com
- bentheelder@google.com
- davanum@gmail.com
- linusa@google.com
- spiffxp@google.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this is instead:

  • IAM for Test Infra folks
  • IAM for WG K8s Infra Leads

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend k8s-infra-prow-oncall@kubernetes.io instead

Suggested change
- ameukam@gmail.com
- bentheelder@google.com
- davanum@gmail.com
- linusa@google.com
- spiffxp@google.com
- k8s-infra-prow-oncall@kubernetes.io
- ameukam@gmail.com

I don't think @listx needs to be included here. @ameukam I would support you moving to k8s-infra-prow-oncall if you're interested

k8s.gcr.io/images/k8s-staging-ci-images/OWNERS Outdated Show resolved Hide resolved
spiffxp
spiffxp approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not use GCR in the k8s-release project: #1110, #846 (comment)

  • avoiding special cases for the pile of bash that maintains all this; k8s-artifacts-prod and the staging projects are the only projects that have populated GCR repositories and I think it would be better to keep it that way
  • GCR repos match project id, so it would have to be gcr.io/k8s-release; I think that's not quite an analogue to kubernetes-ci-images, and might be confusing to see non-releases there

/approve
/lgtm

groups/sig-release/groups.yaml Outdated
Comment on lines 117 to 121
- ameukam@gmail.com
- bentheelder@google.com
- davanum@gmail.com
- linusa@google.com
- spiffxp@google.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend k8s-infra-prow-oncall@kubernetes.io instead

Suggested change
- ameukam@gmail.com
- bentheelder@google.com
- davanum@gmail.com
- linusa@google.com
- spiffxp@google.com
- k8s-infra-prow-oncall@kubernetes.io
- ameukam@gmail.com

I don't think @listx needs to be included here. @ameukam I would support you moving to k8s-infra-prow-oncall if you're interested

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 23, 2020
@ameukam
Copy link
Member Author

ameukam commented Oct 23, 2020

@spiffxp Very interested in being part of this group. Always happy to give some help. :-)

@ameukam
Add Staging GCR repo for kuberntes CI images.
a5623e9 
Add a GCR staging repo that will host images built by
ci-kubernetes-build jobs. It will help migrate those jobs
to k8s-infra-prow-build-cluster.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2020
@justaugustus
Copy link
Member

Okay, let's party!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0649b31 into kubernetes:master Oct 23, 2020
@spiffxp spiffxp mentioned this pull request Oct 26, 2020
Closed
@spiffxp
Copy link
Member

spiffxp commented Dec 3, 2020

This was created to support kubernetes/test-infra#19483

@upodroid
Copy link
Member

@ameukam Do we still need k8s.gcr.io/images/k8s-staging-ci-images/images.yaml today? It has been two years and it is still empty.

I'm working on applying #4277 to all the manifests.

 REDACTED  MCW0CDP3YY  tmp  client  latest  $  gcrane ls us.gcr.io/k8s-ci-images
2022/09/30 14:53:21 No matching credentials were found for "us.gcr.io"
Error: GET https://us.gcr.io/v2/token?scope=repository%3Ak8s-ci-images%3Apull&service=us.gcr.io: UNKNOWN: Project 'project:k8s-ci-images' not found or deleted.
 REDACTED  MCW0CDP3YY  tmp  client  latest  ERROR  $  gcrane ls asia.gcr.io/k8s-ci-images
2022/09/30 14:59:20 No matching credentials were found for "asia.gcr.io"
Error: GET https://asia.gcr.io/v2/token?scope=repository%3Ak8s-ci-images%3Apull&service=asia.gcr.io: UNKNOWN: Project 'project:k8s-ci-images' not found or deleted.
 REDACTED  MCW0CDP3YY  tmp  client  latest  ERROR  $  gcrane ls eu.gcr.io/k8s-ci-images
2022/09/30 14:59:27 No matching credentials were found for "eu.gcr.io"
Error: GET https://eu.gcr.io/v2/token?scope=repository%3Ak8s-ci-images%3Apull&service=eu.gcr.io: UNKNOWN: Project 'project:k8s-ci-images' not found or deleted.

@ameukam
Copy link
Member Author

ameukam commented Sep 30, 2022 •
edited
Loading

@ameukam Do we still need k8s.gcr.io/images/k8s-staging-ci-images/images.yaml today? It has been two years and it is still empty.

I'm working on applying #4277 to all the manifests.

 REDACTED  MCW0CDP3YY  tmp  client  latest  $  gcrane ls us.gcr.io/k8s-ci-images
2022/09/30 14:53:21 No matching credentials were found for "us.gcr.io"
Error: GET https://us.gcr.io/v2/token?scope=repository%3Ak8s-ci-images%3Apull&service=us.gcr.io: UNKNOWN: Project 'project:k8s-ci-images' not found or deleted.
 REDACTED  MCW0CDP3YY  tmp  client  latest  ERROR  $  gcrane ls asia.gcr.io/k8s-ci-images
2022/09/30 14:59:20 No matching credentials were found for "asia.gcr.io"
Error: GET https://asia.gcr.io/v2/token?scope=repository%3Ak8s-ci-images%3Apull&service=asia.gcr.io: UNKNOWN: Project 'project:k8s-ci-images' not found or deleted.
 REDACTED  MCW0CDP3YY  tmp  client  latest  ERROR  $  gcrane ls eu.gcr.io/k8s-ci-images
2022/09/30 14:59:27 No matching credentials were found for "eu.gcr.io"
Error: GET https://eu.gcr.io/v2/token?scope=repository%3Ak8s-ci-images%3Apull&service=eu.gcr.io: UNKNOWN: Project 'project:k8s-ci-images' not found or deleted.

This project is used to build "hourly" k8s images used by other prowjobs. There is no image promotion for this project.

@upodroid upodroid mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@spiffxp spiffxp spiffxp approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@idealhack idealhack Awaiting requested review from idealhack

Assignees

@spiffxp spiffxp

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ameukam @justaugustus @k8s-ci-robot @spiffxp @upodroid