Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test images: Promote newly built E2E test images #1558

Merged
merged 1 commit into from
Jan 21, 2021
Merged

test images: Promote newly built E2E test images #1558

merged 1 commit into from
Jan 21, 2021

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jan 20, 2021 •
edited

These images have been built, as it can be seen here: https://testgrid.k8s.io/sig-testing-images

A few images are not included here yet:

  • echoserver
  • metadata-concealment
  • pets/peer-finder
  • redis

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Jan 20, 2021
@claudiubelu
Copy link
Contributor Author

Presubmit jobs with these images: kubernetes/kubernetes#87607

@spiffxp
Copy link
Member

spiffxp commented Jan 20, 2021

/hold
Not all of these images have been built AFAICT

e.g. recent failures for:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021
@spiffxp spiffxp mentioned this pull request Jan 20, 2021
Merged
spiffxp
spiffxp approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2021
@spiffxp
Copy link
Member

spiffxp commented Jan 21, 2021

Part of #1522, kubernetes/kubernetes#96770

@k8s-ci-robot k8s-ci-robot merged commit c6cd3b8 into kubernetes:master Jan 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 21, 2021
@rajaskakodkar rajaskakodkar mentioned this pull request Jan 22, 2021
Closed
@chewong chewong mentioned this pull request Jan 22, 2021
Merged
@pacoxu pacoxu mentioned this pull request Feb 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@dims dims Awaiting requested review from dims

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@claudiubelu @spiffxp @k8s-ci-robot