Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra/gcp/prow-build: Add bucket for scalability prowjobs #2229

Merged
merged 1 commit into from
Jun 16, 2021
Merged

infra/gcp/prow-build: Add bucket for scalability prowjobs #2229

merged 1 commit into from
Jun 16, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jun 15, 2021

Ref:
#1310 (comment).

Part of #1469.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@ameukam
infra/gcp/prow-build: Add bucket for scalability prowjobs
060902a 
Ref:
kubernetes#1310 (comment).

Part of kubernetes#1469.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 15, 2021
@ameukam
Copy link
Member Author

ameukam commented Jun 15, 2021

/assign @spiffxp

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 15, 2021
spiffxp
spiffxp approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold
remove when ready to deploy

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2021

/hold cancel
I'll deploy post-merge

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit a95c4dd into kubernetes:main Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 16, 2021
@ameukam
Copy link
Member Author

ameukam commented Jun 16, 2021

Deployed successfully.

This was referenced Jun 17, 2021
Merged
Merged
@ameukam
Copy link
Member Author

ameukam commented Jun 18, 2021

Ref #2241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@cjwagner cjwagner Awaiting requested review from cjwagner

@puerco puerco Awaiting requested review from puerco

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ameukam @k8s-ci-robot @spiffxp