Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-public: Enable BigQuery Data Transfer #2749

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 17, 2021

Part of : #1308
Ref: #787
Followup of : #2747

Enable GCP required service for data transfer

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2021
@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ approved Indicates a PR has been approved by an approver from all required OWNERS files. wg/k8s-infra labels Sep 17, 2021
@ameukam
Copy link
Member Author

ameukam commented Sep 17, 2021

This is already deployed.

   enabled:
     - bigquery.googleapis.com
  +  - bigquerydatatransfer.googleapis.com
     - bigquerystorage.googleapis.com
     - billingbudgets.googleapis.com
     - cloudasset.googleapis.com
  @@ -58,8 +59,7 @@ expected:
     - secretmanager.googleapis.com
     - storage-api.googleapis.com
     - storage-component.googleapis.com
  -to_enable:
  -  - bigquerydatatransfer.googleapis.com
  +to_enable: []
   to_disable:
     - bigquerystorage.googleapis.com
     - cloudresourcemanager.googleapis.com

@ameukam
Copy link
Member Author

ameukam commented Sep 17, 2021

cc @dims @spiffxp

Part of : kubernetes#1308
Ref: kubernetes#787
Followup of : kubernetes#2747

Enable GCP required service for data transfer

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added the area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ label Sep 17, 2021
@ameukam
Copy link
Member Author

ameukam commented Sep 17, 2021

I enabled the job and did a manually sync.

 ~ resource "google_bigquery_data_transfer_config" "bq_data_transfer_kettle" {
      ~ disabled                 = true -> false
        id                       = "projects/127754664067/locations/us/transferConfigs/617ffed3-0000-274f-bb87-d4f547e654cc"
        name                     = "projects/127754664067/locations/us/transferConfigs/617ffed3-0000-274f-bb87-d4f547e654cc"
        # (8 unchanged attributes hidden)

      + email_preferences {
          + enable_failure_email = false
        }
    }

@ameukam
Copy link
Member Author

ameukam commented Sep 17, 2021

Transfer was successful for tables

gcloud alpha bq tables list --dataset=k8s_infra_kettle --project kubernetes-public
DATASET_ID        TABLE_ID        CREATION_TIME        EXPIRATION_TIME  TYPE
k8s_infra_kettle  all             2021-09-17T08:06:18                   TABLE
k8s_infra_kettle  all_build_logs  2021-09-17T08:05:58                   TABLE
k8s_infra_kettle  day             2021-09-17T08:05:58                   TABLE
k8s_infra_kettle  staging         2021-09-17T08:06:18                   TABLE
k8s_infra_kettle  week            2021-09-17T08:05:58                   TABLE

but not for the BigQuery views:

Cannot copy table presubmit_times. Copying table is not supported for views, materialized views and external tables.
Cannot copy table week_flakes. Copying table is not supported for views, materialized views and external tables.

Ref: https://cloud.google.com/bigquery/docs/copying-datasets#table_limitations

@spiffxp
Copy link
Member

spiffxp commented Sep 17, 2021

I wouldn't worry about the views not being transferred, AFAIK those are either things humans added, or can be rebuilt by things like kettle, gubernator or triage

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fdc3af9 into kubernetes:main Sep 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants