Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sandbox for CAPG folks testing #2904

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Sandbox for CAPG folks testing #2904

merged 1 commit into from
Oct 8, 2021

Conversation

dims
Copy link
Member

@dims dims commented Oct 8, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Oct 8, 2021
@ameukam
Copy link
Member

ameukam commented Oct 8, 2021

/test pull-k8sio-groups-test

@ameukam
Copy link
Member

ameukam commented Oct 8, 2021

@dims the ML needs to be added to the https://github.com/kubernetes/k8s.io/blob/main/groups/restrictions.yaml.

@dims
Sandbox for CAPG folks testing
965dc01 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the sandbox-for-capg-folks-testing branch from 9c59bc7 to 965dc01 Compare October 8, 2021 20:00
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member

ameukam commented Oct 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 94bfc66 into kubernetes:main Oct 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 8, 2021
@spiffxp spiffxp mentioned this pull request Oct 8, 2021
Merged
@justaugustus justaugustus mentioned this pull request Dec 10, 2021
Closed
@dims dims mentioned this pull request Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp Awaiting requested review from spiffxp

@thockin thockin Awaiting requested review from thockin

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@dims @ameukam @k8s-ci-robot