-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image promotion for artifact-promoter v3.3.0-beta.2-1 #3092
Image promotion for artifact-promoter v3.3.0-beta.2-1 #3092
Conversation
Signed-off-by: Stephen Augustus <foo@auggie.dev>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Testing out the fruits of our labors from kubernetes-sigs/promo-tools#458 and kubernetes-sigs/promo-tools#460. @CecileRobertMichon -- looks like the PR title was successfully fixed (ref: kubernetes-sigs/promo-tools#458 (comment)) |
@@ -12,19 +12,19 @@ | |||
"sha256:768443d88a1c2732adbccdf2d633c35f5a658d92ebf500d0637e2b686e6c239a": ["20200825-v2.3.1-262-g1d9ded6"] | |||
"sha256:799f81d9a855717eab7198310655d1b55919320b120f0f015c3bb43c4e90316d": ["20190821-v2.2.1-2-gc29e4fc"] | |||
"sha256:7c672405701dc7decdf98730708506cc64f502a965893cdb441e4943439b6d28": ["20200107-v2.3.1-71-gfd2fae8"] | |||
"sha256:883e37aa7651b801a2ed55afc774c2b06caa8756a84f43ed5632dc36a92984c0": ["20201027-pkgv0.3.0-7-gf131ef2", "v2.4.1"] | |||
"sha256:883e37aa7651b801a2ed55afc774c2b06caa8756a84f43ed5632dc36a92984c0": ["20201027-pkgv0.3.0-7-gf131ef2","v2.4.1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this file authored manually before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this file authored manually before?
Some aspects of it initially, but this is one of the few manifests that has been using cip-mm
for a while now.
I think what's happening is the grow manifest functionality is stripping spaces in instances where there are multiple tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xref: #3212 (comment)
Superseded by #3171. |
@justaugustus: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Image promotion for artifact-promoter v3.3.0-beta.2-1
This is an automated PR generated from
kpromo
/hold
cc: @kubernetes/release-engineering