Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding CAA record for k8s.io #3179

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

jimangel
Copy link
Member

This is the tail-end of the CAA efforts I started in #1849. First we did kubernetes.io, now this PR is for k8s.io.

An interesting thing to note, I found amazon.com listed when I searched the transparency logs but checking again today (9 months later) I did not see it.

We did identity in a test-infra call that the source was for kops e2e testing (link).

In any event, I don't think it hurts to keep it in but I think we can remove it if new certs haven't been issued in awhile.

/cc @celestehorgan
/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 13, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ labels Dec 13, 2021
@jimangel
Copy link
Member Author

/cc @spiffxp @ameukam

@ameukam
Copy link
Member

ameukam commented Dec 13, 2021

/hold
Let get this merge in 2022

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2021
@sftim
Copy link
Contributor

sftim commented Jan 5, 2022

checks calendar
/unhold

Hope that's OK?

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022
@ameukam
Copy link
Member

ameukam commented Jan 5, 2022

checks calendar /unhold

Hope that's OK?

Not really. Wanted to remove it when we have enough eyes to monitor this change.

Let get this merge in 2022

we have 359 days left.

@sftim
Copy link
Contributor

sftim commented Jan 6, 2022

/hold
Not merging this yet.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022
@ameukam
Copy link
Member

ameukam commented Mar 2, 2022

/lgtm
/assign @dims @cblecker

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
@cblecker
Copy link
Member

cblecker commented Mar 2, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@ameukam
Copy link
Member

ameukam commented Mar 7, 2022

/hold cancel
ref: #2216

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5ed3706 into kubernetes:main Mar 7, 2022
@ameukam
Copy link
Member

ameukam commented Mar 7, 2022

Deployed:

dig CAA k8s.io

; <<>> DiG 9.10.6 <<>> CAA k8s.io
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 29216
;; flags: qr rd ra; QUERY: 1, ANSWER: 3, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
;; QUESTION SECTION:
;k8s.io.				IN	CAA

;; ANSWER SECTION:
k8s.io.			3599	IN	CAA	0 issue "amazon.com"
k8s.io.			3599	IN	CAA	0 issue "letsencrypt.org"
k8s.io.			3599	IN	CAA	0 issue "pki.goog"

;; Query time: 54 msec
;; SERVER: 192.168.1.99#53(192.168.1.99)
;; WHEN: Mon Mar 07 08:15:46 CET 2022
;; MSG SIZE  rcvd: 125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants