Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DNS for CAPI release-1.2 release branch #3872

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

ykakarap
Copy link

DNS updates for Cluster API release-1.2 branch.

Part of: kubernetes-sigs/cluster-api#6615

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2022
@k8s-ci-robot k8s-ci-robot added the area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ label Jun 18, 2022
@ykakarap
Copy link
Author

/cc @sbueringer

@sbueringer
Copy link
Member

/lgtm

/assign @dims
for approval

/hold
I'll unhold when we created the branch in the CAPI repo

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2022
@dims
Copy link
Member

dims commented Jun 20, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ykakarap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@sbueringer
Copy link
Member

/hold cancel

(cc @fabriziopandini)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit c011745 into kubernetes:main Jun 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants