Deploy ESO on EKS #4930
Merged
Deploy ESO on EKS #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/infra
ameukam
reviewed
Mar 13, 2023
infra/aws/terraform/prow-build-cluster/resources/kube-system/tune-sysctls_daemonset.yaml
Outdated
Show resolved
Hide resolved
ameukam
reviewed
Mar 13, 2023
infra/aws/terraform/prow-build-cluster/resources/namespaces.yaml
Outdated
Show resolved
Hide resolved
upodroid
commented
Mar 13, 2023
xmudrii
reviewed
Mar 15, 2023
infra/aws/terraform/prow-build-cluster/resources/external-secrets/configmaps.yaml
Outdated
Show resolved
Hide resolved
| while true; do | ||
| for i in $(seq 0 1000); do | ||
| if ! [ -e /dev/loop$i ]; then | ||
| mknod /dev/loop$i b 7 $i |
There was a problem hiding this comment.
Can we do this via Terraform?
k8s.io/infra/aws/terraform/prow-build-cluster/eks.tf
Lines 104 to 107 in c5181fa
There was a problem hiding this comment.
we can, it is easier to apply the existing manifest :D
infra/aws/terraform/prow-build-cluster/resources/test-pods/test-pods-poddisruptionbudget.yaml
Show resolved
Hide resolved
k8s-ci-robot
added
the
tide/merge-method-squash
|
/approve Leaving the lgtm to @xmudri. ping on slack for the gcp part when ready. |
k8s-ci-robot
added
the
approved
xmudrii
approved these changes
Mar 15, 2023
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, upodroid, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Got │ Error: Error setting IAM policy for service account 'projects/k8s-infra-prow-build/serviceAccounts/kubernetes-external-secrets@k8s-infra-prow-build.iam.gserviceaccount.com': googleapi: Error 400: Invalid principalSet member (principalSet://iam.googleapis.com/projects/773781448124/locations/global/workloadIdentityPools/prow-eks/providers/oidc/attribute.sub/system:serviceaccount:external-secrets:external-secrets)., badRequest
│
│ with module.workload_identity_service_accounts["kubernetes-external-secrets"].google_service_account_iam_policy.serviceaccount_iam,
│ on ../modules/workload-identity-service-account/main.tf line 43, in resource "google_service_account_iam_policy" "serviceaccount_iam":
│ 43: resource "google_service_account_iam_policy" "serviceaccount_iam" {
│
╵during the deployment. |
ameukam
added a commit
to ameukam/k8s.io
that referenced
this pull request
Mar 15, 2023
Follow-up of: - kubernetes#4930 - Fix name of the workload identity provider pool. - Fix a required version of the terraform provider Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
|
Fixing in: #4944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dims @xmudrii @ameukam @BenTheElder
This PR deploys ESO on EKS using Workload Identity Federation. Marko will need to initially apply this manifest, but I intend on creating a prowjob that applies it automatically. We should probably consider using ArgoCD to deploy complex apps bundled as helm charts.
I'll fix the secrets later as I need to upgrade them to new format expected by ESO