Add jobset v0.1.2 and change back v0.1.1 #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
area/artifacts
k8s-ci-robot
added
area/registry.k8s.io
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently tags are immutable, so you cannot change the image digest for a tag, as I attempted to do in #5220. However, this is not enforced at PR-time via tests, but the update will simply silently fail in the image promotion process. I filed #5221 to enforce this immutability on PRs in order to avoid this kind of confusion.
In the meantime, we need to change back the image digest for v0.1.1 in this repo so it matches what is actually in registry.k8s.io, and promote a new image digest for v0.1.2 as the solution to include the changes cherry-picked into the
release-0.1branch of JobSet.We may also want to consider simply deleting v0.1.1 since the tag is on
main, a couple commits ahead ofrelease-0.1, and we can't fix it due to the immutability.cc @ahg-g