-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eks-prow-build: introduce stable node group #6257
Conversation
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alert fatigue :D
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cool. Does this lay the ground for using spot launch more for everything else? |
In a way, but we likely need a more sophisticated cluster-autoscaling solution (e.g. Karpenter) |
Some components are not taking often node rotations well:
#k8s-infra-alerts
upon evicting/rescheduling Flux podsTo mitigate this issue, I created a stable node group, that's not autoscaled, with three nodes. This node group is tainted and it's only going to run these components (and potentially some other components that might benefit from this).
This PR is the first part, there'll be another PR to change manifests for these components. Terraform changes are already applied and the node group has been successfully created.