Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image promotion for cluster-api-helm v0.1.1-alpha.1 #6407

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Image promotion for cluster-api-helm v0.1.1-alpha.1 #6407

merged 1 commit into from
Feb 9, 2024

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Feb 9, 2024

Image promotion for cluster-api-helm v0.1.1-alpha.1
This is an automated PR generated from kpromo

kpromo pr --fork Jont828 --project cluster-api-helm --reviewers "@Jont828 @jackfrancis" --tag v0.1.1-alpha.1 --image cluster-api-helm-controller

/hold
cc: @Jont828 @jackfrancis

@Jont828
Image promotion for cluster-api-helm v0.1.1-alpha.1
d7a5a18 
Signed-off-by: Jonathan Tong <jt572@cornell.edu>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2024
@Jont828
Copy link
Contributor Author

Jont828 commented Feb 9, 2024

@mboersma

@k8s-ci-robot k8s-ci-robot added the area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects label Feb 9, 2024
@k8s-ci-robot k8s-ci-robot added area/registry.k8s.io Code in registry.k8s.io/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Feb 9, 2024
mboersma
mboersma approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Remove the hold when you're ready. 🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024
@Jont828
Copy link
Contributor Author

Jont828 commented Feb 9, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0687d1c into kubernetes:main Feb 9, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
3 participants
@Jont828 @k8s-ci-robot @mboersma