Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Use a temp namespace for k8s-staging-kubernetes promotion #645

Merged
merged 1 commit into from
Mar 9, 2020
Merged

releng: Use a temp namespace for k8s-staging-kubernetes promotion #645

merged 1 commit into from
Mar 9, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Mar 8, 2020 •
edited
Loading

As the k8s.gcr.io VDF (Vanity Domain Flip) hasn't occurred yet, Release Managers should use a temporary namespace (releng-vdf-temp-prod) to test image promotion for production official k8s.gcr.io container images.

Signed-off-by: Stephen Augustus saugustus@vmware.com

@listx -- This shouldn't cause any issues, right?

/assign @thockin @dims @cblecker
cc: @tpepper @kubernetes/release-engineering
ref: kubernetes/release#911

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/k8s-infra labels Mar 8, 2020
@justaugustus justaugustus mentioned this pull request Mar 8, 2020
Open
23 tasks
thockin
thockin reviewed Mar 9, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-prod makes me think it's prod for testing (e.g. tools).

How about releng-test or release-test-do-not-use or something obvious?

@justaugustus
releng: Use a temp namespace for k8s-staging-kubernetes promotion
ff7b745 
As the k8s.gcr.io VDF (Vanity Domain Flip) hasn't occured yet, Release
Managers should use the releng-vdf-temp-prod namespace to test image
promotion for production official k8s.gcr.io container images.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus justaugustus changed the title releng: Use test-prod namespace for k8s-staging-kubernetes promotion releng: Use a temp namespace for k8s-staging-kubernetes promotion Mar 9, 2020
@justaugustus
Copy link
Member Author

How about releng-test or release-test-do-not-use or something obvious?

@thockin -- Good point. Set this to releng-vdf-temp-prod.

thockin
thockin reviewed Mar 9, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit fc264fd into kubernetes:master Mar 9, 2020
@listx
Copy link
Contributor

listx commented Mar 9, 2020

As the k8s.gcr.io VDF (Vanity Domain Flip) hasn't occurred yet, Release Managers should use a temporary namespace (releng-vdf-temp-prod) to test image promotion for production official k8s.gcr.io container images.

Signed-off-by: Stephen Augustus saugustus@vmware.com

@listx -- This shouldn't cause any issues, right?

Should be fine.

@jbeda jbeda mentioned this pull request Mar 26, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@dims dims

@cblecker cblecker

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @listx @thockin @dims @cblecker