Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s-infra-prow-build: fix Grafana volumes #6480

Merged
merged 1 commit into from
Feb 27, 2024
Merged

k8s-infra-prow-build: fix Grafana volumes #6480

merged 1 commit into from
Feb 27, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Feb 27, 2024

Follow up on #6468, #6477, and #6478 to fix post-k8sio-deploy-prow-build-resources failing to deploy the monitoring stack.

We didn't copy all Grafana dashboards from the EKS cluster (for simplicity reasons), so we have to drop/comment some volumes.

/assign @koksay @upodroid @ameukam @dims

@xmudrii
k8s-infra-prow-build: fix Grafana volumes
fded0b5 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@dims
Copy link
Member

dims commented Feb 27, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 27, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit bbbb4d7 into kubernetes:main Feb 27, 2024
3 checks passed
@ameukam
Copy link
Member

ameukam commented Feb 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 27, 2024
@xmudrii xmudrii deleted the gke-grafana-volumes branch February 27, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbpratt jbpratt Awaiting requested review from jbpratt

@mpherman2 mpherman2 Awaiting requested review from mpherman2

Assignees

@dims dims

@ameukam ameukam

@koksay koksay

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
6 participants
@xmudrii @dims @k8s-ci-robot @ameukam @koksay @upodroid