-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastly: Authenticate to a private bucket as origin #6509
Conversation
Define the VCL configuration needed to authenticate to GCS private bucket and use it as origin. This configuration leverage S3 authentification mechanism. The endpoint is currently not publicly exposed. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
I had to pass the variables manually while running |
/hold |
To test. add to the
and run |
Can we at least add a comment outlining how to obtain the values? |
@BenTheElder We could use terraform to passe the values. Put the creds required in a GCP Secret and get them using https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/secret_manager_secret_version. This implies the operator to have some GCP permissions binded to the GCP secret. |
SGTM, I'm also fine with manual (like deploying boskos resources...) as long as we leave some markdown covering how this works for the next people doing this :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Define the VCL configuration needed to authenticate to GCS private bucket and use it as origin. This configuration leverage S3 authentification mechanism.
The endpoint is currently not publicly exposed.