Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPD v0.8.16 image sha256 #6522

Closed
wants to merge 1 commit into from

Conversation

wangzhen127
Copy link
Member

The previous NPD v0.8.16 image sha256 was incorrect. This PR fixes the image sha256 with the correct one. See
https://pantheon.corp.google.com/gcr/images/k8s-staging-npd/global/node-problem-detector@sha256:fc3feff1de8f2b89b5357bf04458e5da75076c83f955271c9b58fc22e4b6678e/details

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Mar 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@ameukam
Copy link
Member

ameukam commented Mar 5, 2024

we don't allow tag mutation. you will need to promote a new tag.

/hold
cc @hakman

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@wangzhen127
Copy link
Member Author

@ameukam Do you mean we need to add v0.8.17?

@ameukam
Copy link
Member

ameukam commented Mar 5, 2024

Yes.

@wangzhen127
Copy link
Member Author

OK...

@wangzhen127 wangzhen127 closed this Mar 5, 2024
@wangzhen127 wangzhen127 deleted the update-npd branch March 5, 2024 17:09
@hakman
Copy link
Member

hakman commented Mar 5, 2024

@wangzhen127 can you approve a new NPD release PR?

@wangzhen127
Copy link
Member Author

I am working on the new v0.8.17 release.

@hakman
Copy link
Member

hakman commented Mar 5, 2024

@wangzhen127 The tag is automatically created by modifying https://github.com/kubernetes/node-problem-detector/blob/master/version.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants