Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image promotion for releng 1.21.9-bookworm-0 #6656

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Image promotion for releng 1.21.9-bookworm-0 #6656

merged 1 commit into from
Apr 5, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 5, 2024

Image promotion for releng 1.21.9-bookworm-0
This is an automated PR generated from kpromo

kpromo pr --fork cpanato --interactive --project releng --tag 1.21.9-bookworm-0

/hold
cc: @kubernetes/release-engineering

@cpanato
Image promotion for releng 1.21.9-bookworm-0
add1b80 
Signed-off-by: Carlos Panato <cpanato@chainguard.dev>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 5, 2024
@cpanato
Copy link
Member Author

cpanato commented Apr 5, 2024

/assign @saschagrunert @xmudrii
/unhold

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
This was referenced Apr 5, 2024
Merged
Closed
MadhavJivrajani
MadhavJivrajani approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Please unhold whenever ready!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Apr 5, 2024

it is ready :)
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0797e0e into kubernetes:main Apr 5, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Apr 5, 2024
@cpanato cpanato deleted the releng-1.21.9-bookworm-0-image-promotion branch April 5, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadhavJivrajani MadhavJivrajani MadhavJivrajani approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@saschagrunert saschagrunert

@MadhavJivrajani MadhavJivrajani

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
5 participants
@cpanato @k8s-ci-robot @MadhavJivrajani @saschagrunert @xmudrii